OSASINFRA-3155 - OpenStack: Create ControlPlaneMachineSet CRDs by pierreprinetti · Pull Request #7280 · openshift/installer

pierreprinetti · 2023-06-26T10:36:43Z

No description provided.

openshift-ci · 2023-06-26T10:36:57Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

pierreprinetti · 2023-06-26T10:37:22Z

/test verify-codegen openstack-manifests unit e2e-openstack-kuryr

pierreprinetti · 2023-06-26T12:55:31Z

/test verify-codegen openstack-manifests unit e2e-openstack-kuryr

pierreprinetti · 2023-06-27T15:27:15Z

/cc emilien mandre JoelSpeed damdo

openshift-ci · 2023-06-27T15:27:40Z

@pierreprinetti: GitHub didn't allow me to request PR reviews from the following users: emilien.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc emilien damdo mandre

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierreprinetti · 2023-06-27T15:27:53Z

/cc emilienm

openshift-ci · 2023-06-27T15:28:12Z

@pierreprinetti: GitHub didn't allow me to request PR reviews from the following users: emilien.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc emilien mandre JoelSpeed damdo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierreprinetti · 2023-06-27T20:30:55Z

/retest-required

docs/user/openstack/control-plane-machine-set.md

EmilienM · 2023-06-28T17:14:47Z

really good work IMO
/lgtm

pierreprinetti · 2023-07-04T07:10:31Z

/test e2e-openstack-kuryr

pierreprinetti · 2023-07-04T12:31:45Z

/test e2e-openstack-kuryr

pkg/asset/machines/openstack/machines.go

docs/user/openstack/control-plane-machine-set.md

r4f4 · 2023-07-06T14:22:52Z

pkg/asset/machines/openstack/machines.go

Suggested change

return nil, nil, fmt.Errorf("failed to generate the Machine providerSpec for replica %d: %w", idx, err)

return nil, nil, errors.Wrapf(err, "failed to generate the Machine providerSpec for replica %d", idx)

Dave Cheney's pkg/errors has been archived and all its functionality has been incorporated into the standard library. I know the dependency is still available in the Installer's go.mod, however I prefer not to use it in new code.

pkg/asset/machines/openstack/machines.go

r4f4 · 2023-07-06T14:39:14Z

/approve

/hold
In case you decide to address the nit comments before merging.

Co-Authored-By: Pierre Prinetti <pierreprinetti@redhat.com> Co-Authored-By: Emilien Macchi <emilien@redhat.com>

openshift-ci · 2023-07-06T14:42:59Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [r4f4]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

EmilienM · 2023-07-06T14:43:50Z

/hold cancel
/lgtm

barbacbd · 2023-07-06T14:46:41Z

pkg/asset/machines/openstack/machines.go

+	}
+
+	// No failure domain is exactly like one failure domain with the default values.
+	if numberOfFailureDomains < 1 {


Suggested change

if numberOfFailureDomains < 1 {

if numberOfFailureDomains == 0 {

barbacbd · 2023-07-06T14:54:18Z

pkg/types/openstack/defaults/machinepool.go

-func DefaultRootVolumeAZ() []string {
-	return []string{""}
+// DefaultRootVolumeAZ returns the default value for Root Volume availability zone.
+func DefaultRootVolumeAZ() string {


nit: Does this need to be a function or can it be a constant ?

It can be a const! Would it be better as a const?

barbacbd · 2023-07-06T14:54:26Z

pkg/types/openstack/defaults/machinepool.go

+}
+
+// DefaultComputeAZ returns the default value for Compute availability zone.
+func DefaultComputeAZ() string {


Same as above.

openshift-ci-robot · 2023-07-06T15:31:09Z

/retest-required

Remaining retests: 0 against base HEAD ccd6238 and 2 for PR HEAD 482a2fe in total

EmilienM · 2023-07-06T19:07:17Z

/test e2e-aws-ovn e2e-openstack-ovn

openshift-ci-robot · 2023-07-06T20:31:17Z

/retest-required

Remaining retests: 0 against base HEAD 30838d9 and 1 for PR HEAD 482a2fe in total

openshift-ci-robot · 2023-07-07T03:31:21Z

/retest-required

Remaining retests: 0 against base HEAD a58142c and 0 for PR HEAD 482a2fe in total

pierreprinetti · 2023-07-07T07:29:26Z

/retest-required

openshift-ci · 2023-07-07T10:30:30Z

@pierreprinetti: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-agent-ha-dualstack	`482a2fe`	link	false	`/test e2e-agent-ha-dualstack`
ci/prow/e2e-openstack-sdn-parallel	`482a2fe`	link	false	`/test e2e-openstack-sdn-parallel`
ci/prow/okd-e2e-aws-ovn	`482a2fe`	link	false	`/test okd-e2e-aws-ovn`
ci/prow/okd-scos-e2e-aws-ovn	`482a2fe`	link	false	`/test okd-scos-e2e-aws-ovn`
ci/prow/okd-e2e-aws-ovn-upgrade	`482a2fe`	link	false	`/test okd-e2e-aws-ovn-upgrade`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2023-07-07T10:31:10Z

/hold

Revision 482a2fe was retested 3 times: holding

pierreprinetti · 2023-07-07T11:59:18Z

/hold cancel
/retry-required

openshift-ci-robot · 2023-07-07T12:31:06Z

/retest-required

Remaining retests: 0 against base HEAD a58142c and 2 for PR HEAD 482a2fe in total

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 26, 2023

pierreprinetti mentioned this pull request Jun 26, 2023

OSASINFRA-3155 - OpenStack: Create ControlPlaneMachineSet CRDs #7136

Closed

pierreprinetti force-pushed the openstack_cpms branch 6 times, most recently from 752525f to 2466500 Compare June 27, 2023 09:46

pierreprinetti marked this pull request as ready for review June 27, 2023 13:04

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 27, 2023

openshift-ci bot requested review from gryf and jhixson74 June 27, 2023 13:05

pierreprinetti force-pushed the openstack_cpms branch from 2466500 to 1f680d5 Compare June 27, 2023 15:25

openshift-ci bot requested a review from damdo June 27, 2023 15:27

openshift-ci bot requested a review from mandre June 27, 2023 15:27

openshift-ci bot requested a review from JoelSpeed June 27, 2023 15:27

openshift-ci bot requested a review from EmilienM June 27, 2023 15:28

pierreprinetti mentioned this pull request Jun 28, 2023

OSASINFRA-3191: Vertically scale masters with CPMS openshift/release#40751

Closed

1 task

EmilienM reviewed Jun 28, 2023

View reviewed changes

docs/user/openstack/control-plane-machine-set.md Outdated Show resolved Hide resolved

openshift-ci bot assigned EmilienM Jun 28, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2023

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 3, 2023

r4f4 reviewed Jul 6, 2023

View reviewed changes

EmilienM mentioned this pull request Jul 6, 2023

e2e: OpenStack CPMS created automatically openshift/cluster-control-plane-machine-set-operator#224

Merged

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 6, 2023

OSASINFRA-3155 - OpenStack: Create ControlPlaneMachineSet CRDs

482a2fe

Co-Authored-By: Pierre Prinetti <pierreprinetti@redhat.com> Co-Authored-By: Emilien Macchi <emilien@redhat.com>

pierreprinetti force-pushed the openstack_cpms branch from 80b1397 to 482a2fe Compare July 6, 2023 14:42

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2023

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2023

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 6, 2023

barbacbd reviewed Jul 6, 2023

View reviewed changes

EmilienM mentioned this pull request Jul 6, 2023

OSASINFRA-3181 - Volume Types for OpenStack CPMS #7300

Merged

7 tasks

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2023

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2023

openshift-merge-robot merged commit 4cb9b2d into openshift:master Jul 8, 2023

pierreprinetti deleted the openstack_cpms branch July 8, 2023 08:13

	return nil, nil, fmt.Errorf("failed to generate the Machine providerSpec for replica %d: %w", idx, err)
	return nil, nil, errors.Wrapf(err, "failed to generate the Machine providerSpec for replica %d", idx)

	if numberOfFailureDomains < 1 {
	if numberOfFailureDomains == 0 {

Conversation

pierreprinetti commented Jun 26, 2023

Uh oh!

openshift-ci bot commented Jun 26, 2023

Uh oh!

pierreprinetti commented Jun 26, 2023

Uh oh!

pierreprinetti commented Jun 26, 2023

Uh oh!

pierreprinetti commented Jun 27, 2023

Uh oh!

openshift-ci bot commented Jun 27, 2023

Uh oh!

pierreprinetti commented Jun 27, 2023

Uh oh!

openshift-ci bot commented Jun 27, 2023

Uh oh!

pierreprinetti commented Jun 27, 2023

Uh oh!

Uh oh!

EmilienM commented Jun 28, 2023

Uh oh!

pierreprinetti commented Jul 4, 2023

Uh oh!

pierreprinetti commented Jul 4, 2023

Uh oh!

Uh oh!

Uh oh!

r4f4 Jul 6, 2023

Choose a reason for hiding this comment

Uh oh!

pierreprinetti Jul 6, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

r4f4 commented Jul 6, 2023

Uh oh!

openshift-ci bot commented Jul 6, 2023

Uh oh!

EmilienM commented Jul 6, 2023

Uh oh!

barbacbd Jul 6, 2023

Choose a reason for hiding this comment

Uh oh!

barbacbd Jul 6, 2023

Choose a reason for hiding this comment

Uh oh!

pierreprinetti Jul 6, 2023

Choose a reason for hiding this comment

Uh oh!

barbacbd Jul 6, 2023

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Jul 6, 2023

Uh oh!

EmilienM commented Jul 6, 2023

Uh oh!

openshift-ci-robot commented Jul 6, 2023

Uh oh!

openshift-ci-robot commented Jul 7, 2023

Uh oh!

pierreprinetti commented Jul 7, 2023

Uh oh!

openshift-ci bot commented Jul 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jul 7, 2023

Uh oh!

pierreprinetti commented Jul 7, 2023

Uh oh!

openshift-ci-robot commented Jul 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

openshift-ci bot commented Jul 7, 2023 •

edited

Loading